-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDK-55450 [NetworkManager] Improve Connectivity Monitoring #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmuhammedrafi
commented
Jan 7, 2025
- new connectivity monitor logic added
- removed startConnectivityMonitor and stopConnectivityMonitor from NetworkManager plugin
- use INetworkManager Enum instead of nsm enums
- modify the UT of connectivity monitor
0a72dc4
to
69cc88a
Compare
69cc88a
to
a55c986
Compare
9e8840b
to
15d27e4
Compare
karuna2git
approved these changes
Jan 15, 2025
karuna2git
added a commit
that referenced
this pull request
Jan 30, 2025
* connectivity monitor clean up change * InetworkManager enums added * start and stop connectivity monitor api removed * log line added * code review comments updated * fix the limited timeout * Update NetworkManager.json * Update NetworkManagerPlugin.md * Update NetworkManager.json * Update NetworkManagerPlugin.md * remove cache logic form workflow --------- Co-authored-by: Karunakaran A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.