-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKB-51547 : [On rbusDirect] Implementation of RBUS Publish API to send Raw Data #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: A Blackduck scan failure has been waivedA prior failure has been upvoted
|
karuna2git
approved these changes
Dec 15, 2023
karuna2git
added a commit
that referenced
this pull request
Jan 12, 2024
* RDKB-51547 : RawData Direct mode with subscription Id Reason for change: Removed topic created with subscriptionId for normal subscription and subscriptionId based topic is only created for rawdata direct mode subscription Test Procedure: Test and verified with rbuscli and testapp Risks: High Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> * RDKB-51547 : RawData Direct mode with subscription Id Reason for change: Removed topic created with subscriptionId for normal subscription and subscriptionId based topic is only created for rawdata direct mode subscription Test Procedure: Test and verified with rbuscli and testapp Risks: High Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send raw data (#191) * RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data Reason for change: Added sample apps for rawdata subscriptions Test Procedure: Build and verified Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> * RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data Reason for change: Added sample apps for rawdata subscriptions Test Procedure: Build and verified Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data (#190) Reason for change: Fixed the ssh failure issue reported in CI testing. Test Procedure: Build and verified Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> RDKB-51547 : [On rbusDirect] Implementation of RBUS Publish API to send Raw Data (#187) Implemented rtConnection_AddListener() and rtConnection_AddListenerWithUID() --------- RDKB-51547 : RawData Direct mode with subscription Id (#176) * RDKB-51547 : RawData Direct mode with subscription Id Reason for change: Implemented rawdata subscription on direct mode with unique subscription Id for each subscription Test Procedure: Test and verified with rbuscli and testapp Risks: High Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> * RDKB-51547 : RawData Direct mode with subscription Id Reason for change: This commit inculded below changes 1. Raw data subscription is only for event type 2. Added unique subscription Id for each subscription in normal and direct mode. 3. Removed support of add listener, remove listener and send message from rbuscli. 4. Addlistener topic name includes subscriptionId. 5. Allowed adding multiple listener of same topic. 6. Removing listener based on the subscription Id. 7. Changes are made to add topic name appropriately when we switch between normal mode and direct mode. 8. Rawdata and subscriptionId data are maintained in the internal event subscription structure maintained by consumer. 9. The subscriptionId from the provider is send to the consumer through the callback handler. 10. Removed master_event_callback(), as individual subscription will invoke the new callback handler(_consumer_event_handler). Test Procedure: Test and verified with rbuscli and testapp Risks: High Priority: P1 Signed-off-by: Gururaaja ESR <[email protected]> * rbus_publishSubscriberEvent Updated the lock --------- Co-Authored-By: Karunakaran A <[email protected]> Co-Authored-By: gururaajar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Added new API for add and remove listener which will work based on the subscription ID. The existing API will remain to support the RDKC build. Also addressed the compile time issue faced for ccspcommonlibrary
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR [email protected]