Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKB-51547 : [On rbusDirect] Implementation of RBUS Publish API to send Raw Data #187

Merged
merged 22 commits into from
Dec 15, 2023

Conversation

gururaajar
Copy link
Contributor

Reason for change: Added new API for add and remove listener which will work based on the subscription ID. The existing API will remain to support the RDKC build. Also addressed the compile time issue faced for ccspcommonlibrary
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR [email protected]

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rbus/187/rdkcentral/rbus

  • Commit: f7ab9cb

Report detail: gist

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rbus/187/rdkcentral/rbus

  • Commit: a2f7b66

Report detail: gist

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rbus/187/rdkcentral/rbus

  • Commit: 7351525

Report detail: gist

@rdkcmf-jenkins
Copy link

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Not a problem

  • Commit: 7351525

@karuna2git karuna2git merged commit 1179aa4 into rdkcentral:main Dec 15, 2023
4 checks passed
karuna2git added a commit that referenced this pull request Jan 12, 2024
* RDKB-51547 : RawData Direct mode with subscription Id

Reason for change: Removed topic created with subscriptionId for
normal subscription and subscriptionId based topic is only created for
rawdata direct mode subscription
Test Procedure: Test and verified with rbuscli and testapp
Risks: High
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

* RDKB-51547 : RawData Direct mode with subscription Id

Reason for change: Removed topic created with subscriptionId for
normal subscription and subscriptionId based topic is only created for
rawdata direct mode subscription
Test Procedure: Test and verified with rbuscli and testapp
Risks: High
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send raw data (#191)

* RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data

Reason for change: Added sample apps for rawdata subscriptions
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

* RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data

Reason for change: Added sample apps for rawdata subscriptions
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

RDKB-51547 - [On rbusDirect] Implementation of RBUS Publish API to send Raw Data (#190)

Reason for change: Fixed the ssh failure issue reported in CI testing.
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

RDKB-51547 : [On rbusDirect] Implementation of RBUS Publish API to send Raw Data (#187)

Implemented rtConnection_AddListener() and rtConnection_AddListenerWithUID()

---------

RDKB-51547 : RawData Direct mode with subscription Id (#176)

* RDKB-51547 : RawData Direct mode with subscription Id

Reason for change: Implemented rawdata subscription on direct mode
with unique subscription Id for each subscription
Test Procedure: Test and verified with rbuscli and testapp
Risks: High
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

* RDKB-51547 : RawData Direct mode with subscription Id

Reason for change: This commit inculded below changes
1.  Raw data subscription is only for event type
2.  Added unique subscription Id for each subscription in normal and direct mode.
3.  Removed support of add listener, remove listener and send message from rbuscli.
4.  Addlistener topic name includes subscriptionId.
5.  Allowed adding multiple listener of same topic.
6.  Removing listener based on the subscription Id.
7.  Changes are made to add topic name appropriately when we switch between normal mode and direct mode.
8.  Rawdata and subscriptionId data are maintained in the internal event subscription structure maintained by consumer.
9.  The subscriptionId from the provider is send to the consumer through the callback handler.
10. Removed master_event_callback(), as individual subscription will invoke the new callback handler(_consumer_event_handler).
Test Procedure: Test and verified with rbuscli and testapp
Risks: High
Priority: P1
Signed-off-by: Gururaaja ESR <[email protected]>

* rbus_publishSubscriberEvent

Updated the lock

---------

Co-Authored-By: Karunakaran A <[email protected]>
Co-Authored-By: gururaajar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants