Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKBDEV-2687 tableSyncHandler callback to avoid undefined behavior while unregistering a row #207

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

alinalabasagemcom
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 31, 2024

CLA assistant check
All committers have signed the CLA.

@alinalabasagemcom alinalabasagemcom force-pushed the fix/RDKBDEV-2687 branch 2 times, most recently from 15c358c to 7e9ea8a Compare June 5, 2024 14:16
@pradeeptakdas
Copy link
Contributor

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-5091

Copy link
Contributor

@karuna2git karuna2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi the changes looks very good to me.
I have just one review comment where I wanted to move rbusElementCallbackTable_t structure to rbus_element.h

It can be merged just moving this.

@@ -549,7 +566,7 @@ typedef rbusError_t (* rbusEventSubHandler_t)(
* data element, the rbus library checks for NULL and substitutes a pointer
* to an error handler function for all unused features
*/
typedef struct rbusCallbackTable_t
typedef struct rbusElementCallbackTable_t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rbusElementCallbackTable_t struct, can we move it to rbus_element.h

Copy link
Contributor

@karuna2git karuna2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test is failing as the callback pointer is changed to void* for method. Could you please address this.

@karuna2git karuna2git merged commit de2749b into rdkcentral:main Oct 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants