-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKBDEV-2687 tableSyncHandler callback to avoid undefined behavior while unregistering a row #207
RDKBDEV-2687 tableSyncHandler callback to avoid undefined behavior while unregistering a row #207
Conversation
15c358c
to
7e9ea8a
Compare
…ile unregistering a row
7e9ea8a
to
5b6a415
Compare
Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-5091 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi the changes looks very good to me.
I have just one review comment where I wanted to move rbusElementCallbackTable_t
structure to rbus_element.h
It can be merged just moving this.
@@ -549,7 +566,7 @@ typedef rbusError_t (* rbusEventSubHandler_t)( | |||
* data element, the rbus library checks for NULL and substitutes a pointer | |||
* to an error handler function for all unused features | |||
*/ | |||
typedef struct rbusCallbackTable_t | |||
typedef struct rbusElementCallbackTable_t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rbusElementCallbackTable_t
struct, can we move it to rbus_element.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit test is failing as the callback pointer is changed to void* for method. Could you please address this.
No description provided.