Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKBDEV-2828: fix line endings in printf strings #214

Closed
wants to merge 3 commits into from

Conversation

pradeeptakdas
Copy link
Contributor

Reason for change:
A DOS line ending is \r\n. A Unix line ending is \n. The sequence \n\r is not a valid line ending on either system.

Test Procedure: Sanity.
Risks: None.

Reason for change:
A DOS line ending is \r\n. A Unix line ending is \n.
The sequence \n\r is not a valid line ending on either system.

Test Procedure: Sanity.
Risks: None.

Signed-off-by: Andre McCurdy <[email protected]>
@pradeeptakdas
Copy link
Contributor Author

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-4966

Copy link
Contributor

@karuna2git karuna2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using linenoise library to print and that requires \r to be in there for rbuscli.
The sample providers and rbus/src can be updated.

@pradeeptakdas
Copy link
Contributor Author

Hi @karuna2git
As per @armcc input - if we we keeping \r it should be before \n. Adding \r after \n is in appropriate.
Can you please review the changes again and provide your input.

If you wish to keep \r before \n, we will make the necessary changes and will submit a new patch-set.

@pradeeptakdas
Copy link
Contributor Author

Duplicate of #224

@pradeeptakdas pradeeptakdas marked this as a duplicate of #224 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants