Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKBDEV-2830: fix memory leak in rbus_invokeRemoteMethod #216

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

pradeeptakdas
Copy link
Contributor

Reason for change:
1,024 bytes in 1 blocks are definitely lost in loss record 318 of 350 malloc (vg_replace_malloc.c:309)
rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2276) rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2269) rbus_getOpenTelemetryContext (rbuscore.c:2290)
rbus_invokeRemoteMethod (rbuscore.c:1064)

Test Procedure: Sanity.
Risks: None.

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

@pradeeptakdas
Copy link
Contributor Author

Internal ticket created for tracking https://ccp.sys.comcast.net/browse/RDKCOM-4964

Reason for change:
1,024 bytes in 1 blocks are definitely lost in loss record 318 of 350
malloc (vg_replace_malloc.c:309)
rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2276)
rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2269)
rbus_getOpenTelemetryContext (rbuscore.c:2290)
rbus_invokeRemoteMethod (rbuscore.c:1064)

Test Procedure: Sanity.
Risks: None.

Signed-off-by: BijeeshaVS <[email protected]>
Copy link
Contributor

@karuna2git karuna2git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release of TelemetryContext must happen only at connection close

@pradeeptakdas
Copy link
Contributor Author

Hi @karuna2git
Can you please review and merge this PR? Please let LGI team know if you have any review comments.

@karuna2git karuna2git merged commit a6d63fc into rdkcentral:main Oct 3, 2024
4 checks passed
karuna2git added a commit that referenced this pull request Jan 7, 2025
* RDKBDEV-2830: fix memory leak in rbus_invokeRemoteMethod

Reason for change:
1,024 bytes in 1 blocks are definitely lost in loss record 318 of 350
malloc (vg_replace_malloc.c:309)
rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2276)
rbus_getOpenTelemetryContextFromThreadLocal (rbuscore.c:2269)
rbus_getOpenTelemetryContext (rbuscore.c:2290)
rbus_invokeRemoteMethod (rbuscore.c:1064)

Test Procedure: Sanity.
Risks: None.

Signed-off-by: BijeeshaVS <[email protected]>

* Update rbuscore.c

---------

Signed-off-by: BijeeshaVS <[email protected]>
Co-authored-by: Andre McCurdy <[email protected]>
Co-authored-by: Karunakaran A <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants