gh #56 L1 and L2 changes for ODM API removal - Phase 1 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arjunbinu
force-pushed
the
feature/gh56_L1_L2_ODM_removal_phase1
branch
2 times, most recently
from
d9c25c2 to
25cc93e
Compare
arjunbinu
commented
Nov 27, 2024
arjunbinu
force-pushed
the
feature/gh56_L1_L2_ODM_removal_phase1
branch
from
7af2e4d to
d9f9e71
Compare
hari22yuva
force-pushed
the
feature/gh56_L1_L2_ODM_removal_phase1
branch
from
86b7bec to
92dd129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAL Header PR
rdkcentral/rdkv-halif-tvsettings#47
Main Objective
The current activity focuses on removing soon-to-be deprecated ODM APIs and types from the TvSettings HAL headers, particularly those exposed to plugins and factory code.
APIs Removed
From include/tvSettingsExtODM.h:
int ReadCapabilitiesFromConfODM(...)
Defintion moved to the plugin.
From include/tvSettingsODM.h:
tvError_t GetSupportedVideoFormatsODM(unsigned int *videoFormats, unsigned short *numberOfFormats)
tvVideoHDRFormat_t GetCurrentVideoFormatODM(void)
tvError_t GetTVSupportedDimmingModesODM(char **dimmingModes, unsigned short *numDimmingModes)
Stubbed replacements are now present in tvSettings.h.
Conversion APIs like ConvertVideoFormatToHDRFormatODM and ConvertHDRFormatToContentFormatODM
Removed due to the deprecation of types like tvhdr_type_t and tvVideoHDRFormat_t.
int GetPanelIDODM(char *panelid)
Moved definition to the plugin. Further updates will encapsulate Panel ID retrieval in Phase 2.
tvError_t TvSyncCalibrationInfoODM()
Removed as the calibration data will now be handled differently.
tvError_t GetTVSupportedDolbyVisionModesODM(pic_modes_t *dvModes[],unsigned short *count)
tvError_t SetWakeupConfig(const tvWakeupSrcType_t src_type, const bool value);
tvError_t SetTVDolbyVisionModeODM(const char * dolbyMode);
int GetCMSDefault(tvComponentType_t component_type);
Note:
Additional function removals are included in preparation for Phase 2.
Modified APIs
In include/tvSettings.h:
tvError_t GetCurrentVideoSource(int *currentSource)
Updated to: tvError_t GetCurrentVideoSource(tvVideoSrcType_t *currentSource)
Rationale: To align with the expected type, ensuring consistency in API usage.
These changes are foundational for the overall API clean-up and ensure the TvSettings HAL interfaces are maintainable, and aligned with the upcoming architectural requirements.