Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh #48 GetTvSupported APIs Allocate memory at caller #49

Merged
merged 8 commits into from
Feb 5, 2025
Merged

gh #48 GetTvSupported APIs Allocate memory at caller #49

merged 8 commits into from
Feb 5, 2025
+41 −8

Conversation

slkanthi
Copy link

@slkanthi slkanthi commented Jan 7, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@slkanthi slkanthi self-assigned this Jan 7, 2025
@slkanthi slkanthi added the documentation Improvements or additions to documentation label Jan 7, 2025
Anbukannadhasan
Anbukannadhasan reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

include/tvSettings.h Outdated Show resolved Hide resolved
include/tvSettings.h Outdated Show resolved Hide resolved
include/tvSettings.h Outdated Show resolved Hide resolved
@slkanthi
gh #48 GetTvSupported APIs - The memory for modes must be allocated a…
ac511ed 
…t caller end.
@slkanthi
Merge branch 'feature/gh48_GetTVSupportedAPI_InputParamCompliance' of…
47853ad 
… rdkcentral-github.com:rdkcentral/rdkv-halif-tvsettings into feature/gh48_GetTVSupportedAPI_InputParamCompliance
Anbukannadhasan
Anbukannadhasan reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the review comments

include/tvSettings.h Outdated Show resolved Hide resolved
Anbukannadhasan
Anbukannadhasan reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added review comments

include/tvSettings.h Outdated Show resolved Hide resolved
Anbukannadhasan
Anbukannadhasan approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Anbukannadhasan Anbukannadhasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

lucienkennedylamb
lucienkennedylamb approved these changes Jan 30, 2025
View reviewed changes
Copy link

@lucienkennedylamb lucienkennedylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's not ideal, but better to keep the function signatures we have.
Good detail on the doxygen comments.

@utkarshece14 utkarshece14 reopened this Feb 4, 2025
utkarshece14
utkarshece14 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@utkarshece14 utkarshece14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hari22yuva hari22yuva merged commit 5723a89 into develop Feb 5, 2025
3 checks passed
@hari22yuva hari22yuva deleted the feature/gh48_GetTVSupportedAPI_InputParamCompliance branch February 5, 2025 10:49
@ddevad ddevad mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarshece14 utkarshece14 utkarshece14 approved these changes

@Anbukannadhasan Anbukannadhasan Anbukannadhasan approved these changes

@lucienkennedylamb lucienkennedylamb lucienkennedylamb approved these changes

Assignees

@slkanthi slkanthi

Labels
documentation Improvements or additions to documentation
Projects
HAL Interface - Upgrades
Status: Resolved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@slkanthi @CLAassistant @lucienkennedylamb @Anbukannadhasan @utkarshece14 @hari22yuva