Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pre-commit): pre-commit autoupdate by ci #1211

Open
wants to merge 26 commits into
base: dependency-updates
Choose a base branch
from

Conversation

dependabot bot and others added 25 commits November 28, 2024 15:59
Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v73.0.0...v74.0.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the babel group with 1 update: [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli).


Updates `@babel/cli` from 7.24.1 to 7.25.6
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.6/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the webpack group with 1 update: [webpack](https://github.com/webpack/webpack).


Updates `webpack` from 5.93.0 to 5.94.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.93.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: webpack
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [django-allauth[openid,socialaccount]](https://github.com/pennersr/django-allauth) to permit the latest version.

Updates `django-allauth[openid,socialaccount]` to 64.2.0
- [Changelog](https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst)
- [Commits](pennersr/django-allauth@64.1.0...64.2.0)

---
updated-dependencies:
- dependency-name: django-allauth[openid,socialaccount]
  dependency-type: direct:production
  dependency-group: django
...

Signed-off-by: dependabot[bot] <[email protected]>
…ith 3 updates

Bumps the dev-dependencies group with 3 updates in the / directory: [babel-loader](https://github.com/babel/babel-loader), [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) and [sass](https://github.com/sass/dart-sass).


Updates `babel-loader` from 9.1.3 to 9.2.1
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v9.1.3...v9.2.1)

Updates `eslint-plugin-react` from 7.35.0 to 7.36.1
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.35.0...v7.36.1)

Updates `sass` from 1.77.1 to 1.79.3
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.77.1...1.79.3)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [setuptools](https://github.com/pypa/setuptools) to permit the latest version.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v73.0.0...v75.1.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the webpack group with 1 update: [webpack](https://github.com/webpack/webpack).


Updates `webpack` from 5.94.0 to 5.95.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.94.0...v5.95.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: webpack
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the prod-dependencies group with 1 update: [date-fns](https://github.com/date-fns/date-fns).


Updates `date-fns` from 3.6.0 to 4.1.0
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/main/CHANGELOG.md)
- [Commits](date-fns/date-fns@v3.6.0...v4.1.0)

---
updated-dependencies:
- dependency-name: date-fns
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: prod-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [importlib-metadata](https://github.com/python/importlib_metadata) to permit the latest version.
- [Release notes](https://github.com/python/importlib_metadata/releases)
- [Changelog](https://github.com/python/importlib_metadata/blob/main/NEWS.rst)
- [Commits](python/importlib_metadata@0.1...v8.5.0)

---
updated-dependencies:
- dependency-name: importlib-metadata
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
---
updated-dependencies:
- dependency-name: django-cleanup
  dependency-type: direct:production
  dependency-group: django
- dependency-name: django-allauth[openid,socialaccount]
  dependency-type: direct:production
  dependency-group: django
...

Signed-off-by: dependabot[bot] <[email protected]>
---
updated-dependencies:
- dependency-name: django-allauth[openid,socialaccount]
  dependency-type: direct:production
  dependency-group: django
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the webpack group with 1 update: [webpack](https://github.com/webpack/webpack).


Updates `webpack` from 5.95.0 to 5.96.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.95.0...v5.96.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: webpack
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the babel group with 3 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) and [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react).


Updates `@babel/core` from 7.25.2 to 7.26.0
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-core)

Updates `@babel/preset-env` from 7.25.3 to 7.26.0
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-preset-env)

Updates `@babel/preset-react` from 7.24.1 to 7.25.9
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.25.9/packages/babel-preset-react)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the react group with 1 update: [react-datepicker](https://github.com/Hacker0x01/react-datepicker).


Updates `react-datepicker` from 7.3.0 to 7.5.0
- [Release notes](https://github.com/Hacker0x01/react-datepicker/releases)
- [Commits](Hacker0x01/react-datepicker@v7.3.0...v7.5.0)

---
updated-dependencies:
- dependency-name: react-datepicker
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: react
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the github-actions group with 1 update: [coverallsapp/github-action](https://github.com/coverallsapp/github-action).


Updates `coverallsapp/github-action` from 2.3.0 to 2.3.4
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Commits](coverallsapp/github-action@643bc37...cfd0633)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the eslint group with 1 update in the / directory: [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react).


Updates `eslint-plugin-react` from 7.36.1 to 7.37.2
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.36.1...v7.37.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.7.2](astral-sh/ruff-pre-commit@v0.6.9...v0.7.2)
- [github.com/pre-commit/mirrors-eslint: v9.12.0 → v9.14.0](pre-commit/mirrors-eslint@v9.12.0...v9.14.0)
- [github.com/crate-ci/typos: v1.26.0 → v1.27.0](crate-ci/typos@v1.26.0...v1.27.0)
Bumps the dev-dependencies group with 1 update in the / directory: [sass](https://github.com/sass/dart-sass).


Updates `sass` from 1.79.3 to 1.81.0
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.79.3...1.81.0)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [pre-commit](https://github.com/pre-commit/pre-commit), [django-auth-ldap](https://github.com/django-auth-ldap/django-auth-ldap), [pytest-cov](https://github.com/pytest-dev/pytest-cov) and [pytest-playwright](https://github.com/microsoft/playwright-pytest) to permit the latest version.

Updates `pre-commit` to 4.0.1
- [Release notes](https://github.com/pre-commit/pre-commit/releases)
- [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md)
- [Commits](pre-commit/pre-commit@v3.4.0...v4.0.1)

Updates `django-auth-ldap` to 5.1.0
- [Release notes](https://github.com/django-auth-ldap/django-auth-ldap/releases)
- [Changelog](https://github.com/django-auth-ldap/django-auth-ldap/blob/master/docs/changes.rst)
- [Commits](django-auth-ldap/django-auth-ldap@4.5.0...5.1.0)

Updates `pytest-cov` to 6.0.0
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v4.1.0...v6.0.0)

Updates `pytest-playwright` to 0.6.2
- [Release notes](https://github.com/microsoft/playwright-pytest/releases)
- [Commits](microsoft/playwright-pytest@v0.4.3...v0.6.2)

---
updated-dependencies:
- dependency-name: pre-commit
  dependency-type: direct:production
  dependency-group: optional
- dependency-name: django-auth-ldap
  dependency-type: direct:production
  dependency-group: optional
- dependency-name: pytest-cov
  dependency-type: direct:production
  dependency-group: optional
- dependency-name: pytest-playwright
  dependency-type: direct:production
  dependency-group: optional
...

Signed-off-by: dependabot[bot] <[email protected]>
…updates/optional-b1f6bcd574

build(deps): bump the optional group across 1 directory with 4 updates
---
updated-dependencies:
- dependency-name: django-allauth[openid,socialaccount]
  dependency-type: direct:production
  dependency-group: django
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [wheel](https://github.com/pypa/wheel) to permit the latest version.
- [Release notes](https://github.com/pypa/wheel/releases)
- [Changelog](https://github.com/pypa/wheel/blob/main/docs/news.rst)
- [Commits](pypa/wheel@0.42.0...0.45.1)

---
updated-dependencies:
- dependency-name: wheel
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@MyPyDavid
Copy link
Member

There are a couple of new ruff lint errors:

ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

rdmo/core/management/commands/find_spam_users.py:135:15: UP031 Use format specifiers instead of percent format
    |
134 |         no_total_users = User.objects.all().count()
135 |         print('Total no of users:    %d' % (no_total_users))
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^ UP031
136 |         potential_spam_users, no_users_having_projects =\
137 |             self.find_potential_spam_users(
    |
    = help: Replace with format specifiers

rdmo/core/management/commands/find_spam_users.py:142:13: UP031 Use format specifiers instead of percent format
    |
141 |         print(
142 |             'Potential spam users: %d  %.2f%% / of which have at least one project %d'
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP031
143 |             % (
144 |                 len(potential_spam_users),
    |
    = help: Replace with format specifiers

rdmo/core/management/commands/find_users.py:102:15: UP031 Use format specifiers instead of percent format
    |
100 |     def handle(self, *args, **options):
101 |         no_total_users = User.objects.all().count()
102 |         print('Total no of users:    %d' % (no_total_users))
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^ UP031
103 |         found_users = self.find_users(options)
    |
    = help: Replace with format specifiers

rdmo/core/management/commands/find_users.py:106:13: UP031 Use format specifiers instead of percent format
    |
105 |         print(
106 |             'Matching the filter:  %d  %.2f%%'
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP031
107 |             % (
108 |                 len(found_users),
    |
    = help: Replace with format specifiers

rdmo/core/utils.py:139:17: UP031 Use format specifiers instead of percent format
    |
137 |         try:
138 |             language = settings.LANGUAGES[i][0], settings.LANGUAGES[i][1],\
139 |                 'lang%i' % (i + 1)
    |                 ^^^^^^^^ UP031
140 |             languages.append(language)
141 |         except IndexError:
    |
    = help: Replace with format specifiers

Found 5 errors.

@MyPyDavid MyPyDavid self-assigned this Dec 4, 2024
@MyPyDavid MyPyDavid added this to the RDMO 2.3.0 milestone Dec 4, 2024
@MyPyDavid MyPyDavid requested a review from triole December 4, 2024 15:28
@jochenklar
Copy link
Member

The one in rdmo/core/utils.py is pretty critical, we should manually check if that still works in Python 3.9. The other ones are becaus of C-style format strings with padding, right?

@MyPyDavid
Copy link
Member

the f-strings have been there since 3.6 (https://docs.python.org/3/reference/lexical_analysis.html#f-strings), that should not break the utils.py.
Padding can also be done in f-strings eg. f'{number:10d}'

@jochenklar
Copy link
Member

I know, but fstrings with a dict f'foo {bar['baz']}' work only with a later version, but I don't remember which.

@MyPyDavid
Copy link
Member

but where is this f-string dict lookup done in this context? It comes as string from the utils function right?

@jochenklar
Copy link
Member

yes, sorry, I was missleading, I am just worried that we use another feature of fstrings which might not be there in Python 3.9.

@MyPyDavid MyPyDavid requested a review from jochenklar December 5, 2024 16:49
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.6](astral-sh/ruff-pre-commit@v0.7.2...v0.8.6)
- [github.com/pre-commit/mirrors-eslint: v9.14.0 → v9.17.0](pre-commit/mirrors-eslint@v9.14.0...v9.17.0)
- [github.com/crate-ci/typos: v1.27.0 → dictgen-v0.3.1](crate-ci/typos@v1.27.0...dictgen-v0.3.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from ffde451 to 73e77a7 Compare January 6, 2025 21:28
@MyPyDavid
Copy link
Member

the bot force pushed the branch, however the fixes for the ruff lint errors can be added by an autofix with ruff I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants