fix: allow data-* and aria-* attributes #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
20 tasks
afc163
reviewed
Mar 15, 2024
src/Collapse.tsx
Outdated
| @@ -81,6 +82,7 @@ const Collapse = React.forwardRef<HTMLDivElement, CollapseProps>((props, ref) => | |||
| className={collapseClassName} | |||
| style={style} | |||
| role={accordion ? 'tablist' : undefined} | |||
| {...restProps} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure! Thank you, done
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 5 5
Lines 114 114
Branches 40 40
=======================================
Hits 113 113
Misses 1 1 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow aria-* and data-* attributes we need to pass spread props inside of container as we're doing for other RC components as I see