feat: Tab Item support icon prop #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
li-jia-nan
commented
Nov 24, 2023
•
li-jia-nan
commented
- Tab Item support icon property ant-design/ant-design#46076
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@afc163 need review |
afc163
reviewed
Nov 25, 2023
| @@ -87,6 +87,7 @@ function TabNode({ | |||
| }} | |||
| onFocus={onFocus} | |||
| > | |||
| {icon} | |||
| {label} | |||
There was a problem hiding this comment.
那我加个 span 标签，在 antd 里面加间距
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 18 18
Lines 678 679 +1
Branches 180 181 +1
=======================================
+ Hits 662 663 +1
Misses 16 16 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Nov 27, 2023
Co-authored-by: MadCcc <[email protected]>
MadCcc
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.