Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accessibility #775

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

aojunhao123
Copy link
Contributor

@aojunhao123 aojunhao123 commented Feb 1, 2025

close ant-design/ant-design#52127
顺便修了一下a11y demo test error
image

Summary by CodeRabbit

  • 新功能
    • 增加了明确的按钮角色属性以提升无障碍体验,便于屏幕阅读器识别。
    • 调整了按钮的焦点行为,改善键盘导航和辅助技术的交互。

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:58pm

Copy link

coderabbitai bot commented Feb 1, 2025

Walkthrough

该提交主要针对 Tab 导航组件的无障碍支持进行优化。具体来说,在 AddButtonTabNode 组件中新增了 role="tab" 属性,而在 OperationNode 组件中移除了按钮元素的 tabIndexaria-hidden 属性。这些改动旨在避免无障碍焦点问题,提升组件与辅助技术的交互体验,同时未涉及业务逻辑的实质性修改。

Changes

File(s) Change Summary
src/TabNavList/AddButton.tsx
src/TabNavList/TabNode.tsx
为按钮元素新增 role="tab" 属性,增强无障碍描述
src/TabNavList/OperationNode.tsx 移除按钮元素上的 tabIndexaria-hidden 属性,以修正焦点错误

Assessment against linked issues

Objective ([#52127]) Addressed Explanation
修复点击折叠项按钮导致的焦点错误,避免 aria-hidden 影响已聚焦元素问题

Possibly related PRs

Suggested reviewers

  • zombieJ

Poem

我是一只快乐的小兔,穿梭代码间,
角色标签闪烁如星光,轻盈跳跃无限欢,
删去多余属性烦恼,焦点清晰映天边,
在 Tab 的舞台上留诗行,🐰传递无障碍的新篇。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aojunhao123
Copy link
Contributor Author

@afc163 大佬有空瞅瞅

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (9cfae99) to head (d710101).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          18       18           
  Lines         774      774           
  Branches      224      220    -4     
=======================================
  Hits          766      766           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cfae99 and 19464a7.

⛔ Files ignored due to path filters (2)
  • tests/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/overflow.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • src/TabNavList/AddButton.tsx (1 hunks)
  • src/TabNavList/OperationNode.tsx (0 hunks)
  • src/TabNavList/TabNode.tsx (1 hunks)
💤 Files with no reviewable changes (1)
  • src/TabNavList/OperationNode.tsx
✅ Files skipped from review due to trivial changes (1)
  • src/TabNavList/TabNode.tsx

@afc163 afc163 merged commit cab13b8 into react-component:master Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tabs] clicking the folded item button will result in an error
2 participants