fix: setup lint

react-native-picker · Apr 17, 2024 · d22e016 · d22e016
1 parent 766cf4f
commit d22e016
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 16 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Dependencies
         run: yarn
       - name: ESLint Checks
-        run: yarn validate:eslint
+        run: yarn lint
   flow:
     runs-on: ubuntu-latest
     strategy:
@@ -43,7 +43,7 @@ jobs:
       - name: Install Dependencies
         run: yarn
       - name: Flow Checks
-        run: yarn validate:flow
+        run: yarn flow
   tsc:
     runs-on: ubuntu-latest
     strategy:
@@ -64,7 +64,7 @@ jobs:
       - name: Install Dependencies
         run: yarn
       - name: TypeScript type check
-        run: yarn validate:typescript
+        run: yarn typecheck
   android:
     runs-on: ubuntu-latest
     strategy:

diff --git a/package.json b/package.json
@@ -2,7 +2,9 @@
   "author": "Jesse Katsumata <[email protected]> (Naturalclar)",
   "description": "React Native Picker for iOS, Android, macOS, and Windows",
   "scripts": {
-    "lint": "turbo lint"
+    "lint": "turbo lint",
+    "flow": "turbo flow",
+    "typecheck":"turbo typecheck"
   },
   "devDependencies": {
     "@react-native/eslint-config": "^0.72.2",

diff --git a/packages/example/.prettierrc b/packages/example/.prettierrc
@@ -0,0 +1,7 @@
+{
+  "singleQuote": true,
+  "trailingComma": "all",
+  "bracketSpacing": false,
+  "jsxBracketSameLine": true,
+  "parser": "flow"
+}
diff --git a/packages/example/App.tsx b/packages/example/App.tsx
@@ -26,7 +26,7 @@ import {
 } from 'react-native/Libraries/NewAppScreen';
 
 type SectionProps = PropsWithChildren<{
-  title: string;
+  title: string,
 }>;
 
 function Section({children, title}: SectionProps): React.JSX.Element {

diff --git a/packages/example/metro.config.js b/packages/example/metro.config.js
@@ -1,4 +1,4 @@
-const { makeMetroConfig } = require("@rnx-kit/metro-config");
+const {makeMetroConfig} = require('@rnx-kit/metro-config');
 module.exports = makeMetroConfig({
   transformer: {
     getTransformOptions: async () => ({

diff --git a/packages/example/react-native.config.js b/packages/example/react-native.config.js
@@ -1,16 +1,16 @@
 const project = (() => {
   try {
-    const { configureProjects } = require("react-native-test-app");
+    const {configureProjects} = require('react-native-test-app');
     return configureProjects({
       android: {
-        sourceDir: "android",
+        sourceDir: 'android',
       },
       ios: {
-        sourceDir: "ios",
+        sourceDir: 'ios',
       },
       windows: {
-        sourceDir: "windows",
-        solutionFile: "windows/Example.sln",
+        sourceDir: 'windows',
+        solutionFile: 'windows/Example.sln',
       },
     });
   } catch (_) {
@@ -19,5 +19,5 @@ const project = (() => {
 })();
 
 module.exports = {
-  ...(project ? { project } : undefined),
+  ...(project ? {project} : undefined),
 };
diff --git a/packages/picker/babel.config.js b/packages/picker/babel.config.js
@@ -0,0 +1,3 @@
+module.exports = {
+  presets: ['module:metro-react-native-babel-preset'],
+};
diff --git a/packages/picker/package.json b/packages/picker/package.json
@@ -47,9 +47,6 @@
     "babel-jest": "^26.6.3",
     "babel-plugin-module-resolver": "^3.2.0",
     "detox": "^17.10.6",
-    "eslint": "^8.4.1",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-prettier": "^4.0.0",
     "expo": "^41.0.1",
     "flow-bin": "0.222.0",
     "husky": "^2.2.0",

diff --git a/yarn.lock b/yarn.lock
@@ -8667,7 +8667,7 @@ eslint-plugin-jest@^26.5.3:
   dependencies:
     "@typescript-eslint/utils" "^5.10.0"
 
-eslint-plugin-prettier@^4.0.0, eslint-plugin-prettier@^4.2.1:
+eslint-plugin-prettier@^4.2.1:
   version "4.2.1"
   resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz#651cbb88b1dab98bfd42f017a12fa6b2d993f94b"
   integrity sha512-f/0rXLXUt0oFYs8ra4w49wYZBG5GKZpAYsJSm6rnYL5uVDjd+zowwMwVZHnAjf4edNrKpCDYfXDgmRE/Ak7QyQ==