Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy version check in react-native.config.js #586

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lukmccall
Copy link
Contributor

Description

Removes legacy version check from react-native.config.js.

Changes

The community CLI is no longer a dependency for React Native, meaning it may not be installed in every project. For example, projects that use Expo won't include the @react-native-community/cli-* packages. Consequently, this check will fail, leading to issues with autolinking components.

This version check can be removed safely, as the 9th version of the CLI was released two years ago.

Tests

This change was tested using expo project on react native 0.76.

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naturalclar Naturalclar merged commit 7ec8072 into react-native-picker:master Oct 25, 2024
6 of 12 checks passed
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants