Template params can only have one argument #63
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
SimonFrings
approved these changes
Jan 24, 2023
clue
approved these changes
Jan 24, 2023
|
Just noticed this should also be applied to the README documentation. @WyriHaximus is this something you can look into? 👍 |
WyriHaximus
deleted the
1.x-template-params-can-only-have-one-argument
branch
WyriHaximus
added a commit
to WyriHaximus-secret-labs/promise-timer
that referenced
this pull request
Jan 24, 2023
In the previous PR (reactphp#63) I missed incorrect usage in the readme, this PR addresses that. The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.
Refs: reactphp/promise#223