Rdh resource fetcher plugin #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielweck
reviewed
Nov 28, 2016
|
|
||
| var resourcePluginKey='ResourceFetcherPlugin'; | ||
| var plugins = ReadiumSDK.Plugins.getLoadedPlugins() | ||
| if (_.has(plugins, resourcePluginKey)) { |
There was a problem hiding this comment.
Another way to test for whether or not a plugin is loaded, based on its registered name:
https://github.com/readium/readium-js/blob/develop/dev/index.js#L146
if (ReadiumSDK.reader.plugins.ResourceFetcherPlugin) {
...
}(I'm not 100% sure that ReadiumSDK.reader is valid ... to be verified)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is Finalized
Related issue(s) and/or pull request(s)
See also #144*
Test cases, sample files
Additional information
This code allows for a resource fetcher plugin. If one is specified, then it is used in place of the built-in resource fetchers.
The Bibliotheca hybrid app uses this to load a resource fetcher that gets content from an API.
Some thoughts on this code:
in publication_fetcher.js, about line 137, the code is slightly different between the base code and this code; specifically I removed isExploded(). I'm not sure if that is a breaking change for users that don't have a plugin.
It would be nice to move the existing resource fetchers to plugins as well.
I don't know how to clear up the "readium_shared_js" issue that I see at the bottom of this pull request.