Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): adding support for OpenAPI 3.1.1, 3.0.4 and basic auth fetches #1153

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix(openapi): adding support for OpenAPI 3.1.1, 3.0.4 and basic auth fetches #1153

merged 1 commit into from
Jan 25, 2025
+28 −57

Conversation

erunion
Copy link
Member

@erunion erunion commented Jan 25, 2025

🚥 Resolves #1152

🧰 Changes

This upgrades oas-normalize and oas in order to pull in updates made to our OpenAPI parser to support OpenAPI 3.0.4 and 3.1.1 definitions. I have also made a fix in oas-normalize to support basic auth credentials in URLs, which will fix #1152.

Also upgraded nock to v14 while I'm here because that dropped today.

@erunion erunion added bug enhancement New feature or request dependencies Pull requests that update a dependency file command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands labels Jan 25, 2025
@erunion erunion requested a review from kanadgupta January 25, 2025 00:30
erunion
erunion commented Jan 25, 2025
View reviewed changes
package.json
@@ -72,7 +72,7 @@
"@commitlint/cli": "^19.0.3",
"@commitlint/config-conventional": "^19.0.3",
"@oclif/test": "^4.1.0",
"@readme/better-ajv-errors": "^1.5.0",
"@readme/better-ajv-errors": "^2.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got a major bump because I dropped support for Node 16 (finally).

@kanadgupta kanadgupta merged commit 6fad02b into next Jan 25, 2025
8 checks passed
@kanadgupta kanadgupta deleted the feat/upgrade-oas-normalize branch January 25, 2025 02:24
kanadgupta pushed a commit that referenced this pull request Jan 25, 2025
@semantic-release-bot
build(release): 🚀 v10.1.1-next.1 🦉
d91d535 
## [10.1.1-next.1](v10.1.0...v10.1.1-next.1) (2025-01-25)

### Bug Fixes

* **openapi:** adding support for OpenAPI 3.1.1, 3.0.4 and basic auth fetches ([#1153](#1153)) ([6fad02b](6fad02b)), closes [#1152](#1152)

[skip ci]
@kanadgupta
Copy link
Member

🎉 This PR is included in version 10.1.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kanadgupta pushed a commit that referenced this pull request Jan 28, 2025
@semantic-release-bot
build(release): 🚀 v10.1.1 🦉
e770fc3 
## [10.1.1](v10.1.0...v10.1.1) (2025-01-28)

### Bug Fixes

* **openapi:** adding support for OpenAPI 3.1.1, 3.0.4 and basic auth fetches ([#1153](#1153)) ([6fad02b](6fad02b)), closes [#1152](#1152)

[skip ci]
@kanadgupta
Copy link
Member

🎉 This PR is included in version 10.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kanadgupta kanadgupta mentioned this pull request Feb 3, 2025
Merged
kanadgupta added a commit that referenced this pull request Feb 3, 2025
@kanadgupta
chore(deps/v9): bump (#1164)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
93570de 
## 🧰 Changes

before:

```
Package                                        Current   Wanted   Latest  Location                                             Depended by
@commitlint/cli                                 19.6.1   19.7.1   19.7.1  node_modules/@commitlint/cli                         rdme
@commitlint/config-conventional                 19.6.0   19.7.1   19.7.1  node_modules/@commitlint/config-conventional         rdme
@oclif/core                                      4.2.1    4.2.6    4.2.6  node_modules/@oclif/core                             rdme
@oclif/plugin-autocomplete                      3.2.16   3.2.20   3.2.20  node_modules/@oclif/plugin-autocomplete              rdme
@oclif/plugin-help                              6.2.20   6.2.24   6.2.24  node_modules/@oclif/plugin-help                      rdme
@oclif/plugin-not-found                         3.2.33   3.2.40   3.2.40  node_modules/@oclif/plugin-not-found                 rdme
@oclif/plugin-warn-if-update-available          3.1.29   3.1.32   3.1.32  node_modules/@oclif/plugin-warn-if-update-available  rdme
@oclif/test                                      4.1.6    4.1.9    4.1.9  node_modules/@oclif/test                             rdme
@readme/better-ajv-errors                        1.6.0    1.6.0    2.1.2  node_modules/@readme/better-ajv-errors               rdme
@vitest/coverage-v8                              2.1.8    2.1.9    3.0.5  node_modules/@vitest/coverage-v8                     rdme
@vitest/expect                                   2.1.8    2.1.9    3.0.5  node_modules/@vitest/expect                          rdme
eslint                                          8.57.1   8.57.1   9.19.0  node_modules/eslint                                  rdme
ignore                                           7.0.0    7.0.3    7.0.3  node_modules/ignore                                  rdme
knip                                            5.41.1   5.43.6   5.43.6  node_modules/knip                                    rdme
nock                                    14.0.0-beta.19   14.0.0   14.0.0  node_modules/nock                                    rdme
oas                                             25.2.1   25.3.0   25.3.0  node_modules/oas                                     rdme
oas-normalize                                   12.0.0   12.1.0   12.1.0  node_modules/oas-normalize                           rdme
oclif                                          4.17.10  4.17.25  4.17.25  node_modules/oclif                                   rdme
ora                                              8.1.1    8.2.0    8.2.0  node_modules/ora                                     rdme
rollup                                          4.30.0   4.34.1   4.34.1  node_modules/rollup                                  rdme
semver                                           7.6.3    7.7.0    7.7.0  node_modules/semver                                  rdme
type-fest                                       4.31.0   4.33.0   4.33.0  node_modules/type-fest                               rdme
typescript                                       5.7.2    5.7.3    5.7.3  node_modules/typescript                              rdme
undici                                          5.28.4   5.28.5    7.3.0  node_modules/undici                                  rdme
vitest                                           2.1.8    2.1.9    3.0.5  node_modules/vitest                                  rdme
```

after:

```
Package  Current  Wanted  Latest  Location             Depended by
eslint    8.57.1  8.57.1  9.19.0  node_modules/eslint  rdme
undici    5.28.5  5.28.5   7.3.0  node_modules/undici  rdme
```

as part of this, v9 now supports OAS v3.0.4 and 3.1.1. more info in
#1153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta

Assignees
No one assigned
Labels
command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands dependencies Pull requests that update a dependency file enhancement New feature or request released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI doesn't support basic authentication in the URL since 9.0.0
2 participants
@erunion @kanadgupta