test: more enhancements #1190
Merged
test: more enhancements #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
refactor
erunion
approved these changes
Mar 5, 2025
| @@ -51,7 +51,7 @@ polymorphism: | |||
| `; | |||
|
|
|||
| exports[`rdme openapi inspect > feature reports > should generate a report for '@readme/oas-examples/3.0/json/readme-…' (w/ [ 'readme' ]) 1`] = ` | |||
| " | |||
| [SoftError: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
he got me. that f***ing kanad gupta boomed me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
continuing my work in #1188 with even more work to migrate over our tests to the more comprehensive
runCommandhelper:openapi convertopenapi inspectopenapi reduceloginlogoutwhoamithe only outstanding tests using the now deprecated
runCommandAndReturnResulthelper are the changelog tests, but i'll swap those out if/when we get around to migrating that command over to APIv2.🧬 QA & Testing
no functional changes. do tests still pass?