Search: small updates on look & feel #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on my feedback from #496
humitos
changed the title
|
Those are some great updates! One thing to be careful of is AA, the text color looks like it doesn't have enough contract with the background. You can check this in Firefox with right clicking the element and "Inspect Accessibility properties". |
agjohnson
reviewed
Jan 15, 2025
|
Cool, I reviewed and updated the colors to follow the standards. This PR is ready for re-review and merge. |
ericholscher
approved these changes
Jan 16, 2025
|
I did the last change requested. I'm going ahead and merging this PR, but I'm happy to continue improving the look & feel on further PRs 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my feedback from #496
This is the results. I think it looks a lot better, more compacted and easy to quickly scan.
Closes #496
Closes #419