Add Flights to the AnalyzedAdvertiserUrl for targeting #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us explicit control over the URLs to target for each flight. By default the URLs from the ads in the current flight will be added on creation, but we can manually adjust this.
This is required to get updated ad URLs into targeting.
davidfischer
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
This looks like it should be an improvement. So we can have a URL tied to the flight that is NOT one of the ad URLs, correct? That seems like the right approach as I suspect product pages will be what we want to analyze and the landing page may not always be the best fit.
| @@ -14,6 +14,8 @@ | |||
| from djstripe.models import Invoice | |||
| from simple_history.admin import SimpleHistoryAdmin | |||
|
|
|||
| from adserver.analyzer.models import AnalyzedAdvertiserUrl | |||
There was a problem hiding this comment.
I do wonder about this for folks who have the analyzer disabled.
There was a problem hiding this comment.
I think we should probably just fully migrate the analyzer over to ext, tbh. There's definitely a bunch of split brain stuff happening in this PR, and I think that's likely the cleanest thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us explicit control over the URLs to target for each flight.
By default the URLs from the ads in the current flight will be added on creation,
but we can manually adjust this.