Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post: partially or completely override the build process #345

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

@stsewd stsewd requested a review from a team as a code owner January 14, 2025 15:23
@stsewd stsewd requested a review from ericholscher January 14, 2025 15:23
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with some modifications.

content/posts/override-build-process-with-build-jobs.md Outdated Show resolved Hide resolved
content/posts/override-build-process-with-build-jobs.md Outdated Show resolved Hide resolved
content/posts/override-build-process-with-build-jobs.md Outdated Show resolved Hide resolved
content/posts/override-build-process-with-build-jobs.md Outdated Show resolved Hide resolved
@stsewd stsewd requested a review from humitos January 15, 2025 19:27
content/posts/override-build-process-with-build-jobs.md Outdated Show resolved Hide resolved
Comment on lines +77 to +79
We recommend using [`build.jobs`](https://docs.readthedocs.io/en/stable/config-file/v2.html#build-jobs) over [`build.commands`](https://docs.readthedocs.io/en/stable/config-file/v2.html#build-commands),
as it offers the same functionality as `build.commands`, but in a more structured way that allows you to define different commands for each format,
while also supporting installing system dependencies via `build.apt_packages`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably put a section in the docs about when each should be used. I think build.commands is basically for when you want us to run no additional setup, and the reason apt_packages doesn't work is because we aren't doing any kind of environment setup, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.jobs can also be used to not run any additional steps, they are basically the same now.

@stsewd stsewd merged commit 75cbff8 into main Jan 20, 2025
4 checks passed
@stsewd stsewd deleted the build-override branch January 20, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants