Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure accurate mapping in AvatarBoneMirror class #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyunaseo
Copy link

  • Corrected logic in SetMirroredBonePair to avoid incorrect mapping caused by FindChildRecursive.
  • Ensured that the correct child transforms are matched with their mirrored counterparts.
  • Prevents mapping issues where Rendered_Head was matched instead of Head.

TICKETID

Description

  • This change fixes an issue in the AvatarBoneMirror class, specifically in the SetMirroredBonePair method, where incorrect bone mapping occurred due to the improper use of FindChildRecursive. The fix ensures correct child transforms, like Head, are matched with their mirrored counterparts, avoiding incorrect pairs like Rendered_Head.

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

- Corrected logic in SetMirroredBonePair to avoid incorrect mapping caused by FindChildRecursive.
- Ensured that the correct child transforms are matched with their mirrored counterparts.
- Prevents mapping issues where Rendered_Head was matched instead of Head.
@hyunaseo hyunaseo requested a review from a team as a code owner January 28, 2025 13:41
@hyunaseo hyunaseo changed the title Fix: Ensure accurate mapping of bones during mirror pairing Fix: Ensure accurate mapping in AvatarBoneMirror class Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant