-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!-- Copy the TICKETID for this task from Monday and add it to the PR name in brackets --> <!-- PR name should look like: [TICKETID] My Pull Request --> <!-- Add link for the ticket here editing the TICKETID--> ## [SDK-524](https://ready-player-me.atlassian.net/browse/SDK-524) ## Description - Multimesh support updates <!-- Fill the section below with Added, Updated and Removed. --> <!-- If there is no item under one of the lists remove it's title. --> <!-- Testability --> ## How to Test - Import the release branch into a RPM Unity project and run the sample <!-- Update your progress with the task here --> ## Checklist - [x] Tests are written and are passing - [ ] Documentation is updated. - [x] Changelog is updated [SDK-524]: https://ready-player-me.atlassian.net/browse/SDK-524?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Harrison Hough <[email protected]> Co-authored-by: Robin <[email protected]>
- Loading branch information
1 parent
d2ecf96
commit 0cead02
Showing
77 changed files
with
308 additions
and
138,697 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# These owners will be the default owners for everything in | ||
# the repo. Unless a later match takes precedence, | ||
# @readyplayerme/onboarding-integrations be requested for | ||
# review when someone opens a pull request. | ||
* @readyplayerme/onboarding-integrations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: bug | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
|
||
**Files** | ||
|
||
Attach or link to .glb files or avatar URL that trigger the bug. | ||
|
||
In addition, make sure to run those files through the example scenes first. If you encounter errors or warnings, try to make sure they are not responsible for the issue. | ||
|
||
> Note: You have to ZIP archive them first in order for GitHub to accept the upload. | ||
If your files are confidential: | ||
|
||
- Try to create a similar, but intellectual-property-free Unity example project or build that reproduces the bug in the same way (so any community member can have a look) | ||
- Otherwise, still create this issue and send the files (or a link to them) discretely via email | ||
|
||
**To Reproduce** | ||
Steps to reproduce the behavior: | ||
1. Go to '...' | ||
2. Click on '....' | ||
3. Scroll down to '....' | ||
4. See error | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
**Screenshots** | ||
If applicable, add screenshots to help explain your problem. | ||
|
||
**Desktop (please complete the following information):** | ||
- Ready Player Me Core version | ||
- Ready Player Me WebView version (If relevant) | ||
- glTFast version | ||
- Unity Editor version [e.g. 2021.2.1f1] | ||
- Render Pipeline and version [e.g. Universal Render Pipeline 12.0] | ||
- Operating System [e.g. Windows, Mac, Linux ] | ||
- Platform: [e.g. Editor , Windows Player, iOS] | ||
|
||
additionally (if significant for the bug): | ||
|
||
- Device: [e.g. iPhone6] | ||
- OS: [e.g. iOS8.1] | ||
- For WebGL: Browser [e.g. stock browser, safari] | ||
|
||
**Additional context** | ||
Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: enhancement | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. e.g. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
using ReadyPlayerMe.Core.Editor; | ||
using UnityEditor; | ||
|
||
public abstract class DependencyInstaller | ||
{ | ||
private const string NETCODE_SUPPORT_PACKAGE_NAME = "com.readyplayerme.netcodesupport"; | ||
private const string NETCODE_HELPER_PACKAGE = "https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop.git?path=/Packages/com.unity.multiplayer.samples.coop#main"; | ||
private const string DIALOG_MESSAGE = "This package depends on - com.unity.multiplayer.samples.coop. Do you want to install it?"; | ||
|
||
[InitializeOnLoadMethod] | ||
private static void Initialize() | ||
{ | ||
PackageManagerEventListener.OnPackageImported += OnPackageImported; | ||
} | ||
|
||
~DependencyInstaller() | ||
{ | ||
PackageManagerEventListener.OnPackageImported -= OnPackageImported; | ||
} | ||
|
||
private static void OnPackageImported(string packageName) | ||
{ | ||
if (packageName != NETCODE_SUPPORT_PACKAGE_NAME) | ||
{ | ||
return; | ||
} | ||
|
||
if (PackageManagerHelper.IsPackageInstalled(NETCODE_HELPER_PACKAGE)) | ||
{ | ||
return; | ||
} | ||
|
||
if (EditorUtility.DisplayDialog("Ready Player Me", DIALOG_MESSAGE, "OK", "Cancel")) | ||
{ | ||
PackageManagerHelper.AddPackage(NETCODE_HELPER_PACKAGE); | ||
} | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
...tingGame/Scripts/CameraController.cs.meta → Editor/DependencyInstaller.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.