Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quart integration #346

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

hrimov
Copy link

@hrimov hrimov commented Jan 18, 2025

Adds integration for the Quart framework, including websockets. The implementation follows the Flask integration pattern due to their similar APIs.

@Tishka17
Copy link
Member

That's a create job, thank you. I am not sure, we need more web-frameworks as a mainstream integration. What do you think about publishing as a separate project? We had an internal discussion last year about community driven integration, so probably time has come to start doing it.

What I suggest:

  • you prepare a separate github repository under your control.
  • you publish as a separate project on pypi (name like dishka-quart whould be ok)
  • we add a link to your project into dishka documentation

Based on this work we can together prepare a template repo for future integrations.

What do you think about this approach?

@hrimov
Copy link
Author

hrimov commented Jan 19, 2025

I see... I just want to say that my main motivation for creating this integration was to better understand dishka's internals :) But I guess it wouldn't be a problem to create a separate package for it.

However, what is the main point of proceeding with community-driven integrations? Is it because of the lack of "free hands" or due to the desire to make the distribution more lightweight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants