Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --only-rule option to common arguments #5981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SimplyDanny
Copy link
Collaborator Author

@mildm8nnered: I don't see a reason to have them not in the common part. You?

@SwiftLintBot
Copy link

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
18 Messages
📖 Building this branch resulted in the same binary size as when built on main.
📖 Linting Aerial with this PR took 1.7 s vs 0.96 s on main (77% slower).
📖 Linting Alamofire with this PR took 1.28 s vs 1.29 s on main (0% faster).
📖 Linting Brave with this PR took 8.69 s vs 8.71 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 5.61 s vs 5.63 s on main (0% faster).
📖 Linting Firefox with this PR took 11.75 s vs 11.76 s on main (0% faster).
📖 Linting Kickstarter with this PR took 10.61 s vs 10.62 s on main (0% faster).
📖 Linting Moya with this PR took 0.55 s vs 0.54 s on main (1% slower).
📖 Linting NetNewsWire with this PR took 2.94 s vs 2.95 s on main (0% faster).
📖 Linting Nimble with this PR took 0.82 s vs 0.81 s on main (1% slower).
📖 Linting PocketCasts with this PR took 8.91 s vs 8.87 s on main (0% slower).
📖 Linting Quick with this PR took 0.45 s vs 0.46 s on main (2% faster).
📖 Linting Realm with this PR took 4.56 s vs 4.58 s on main (0% faster).
📖 Linting Sourcery with this PR took 2.35 s vs 2.35 s on main (0% slower).
📖 Linting Swift with this PR took 4.73 s vs 4.74 s on main (0% faster).
📖 Linting VLC with this PR took 1.25 s vs 1.27 s on main (1% faster).
📖 Linting Wire with this PR took 18.92 s vs 18.89 s on main (0% slower).
📖 Linting WordPress with this PR took 11.67 s vs 11.66 s on main (0% slower).

Here's an example of your CHANGELOG entry:

* Move `--only-rule` option to common arguments.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants