Updated baas-test-server to use the arm64 docker image #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
approved these changes
Dec 5, 2023
| const dylibFilename = "libstitch_support.dylib"; | ||
| const dylibUsrLocalLibPath = "/usr/local/lib/" + dylibFilename; | ||
| const assistedAggPath = path.resolve(baasPath, "assisted_agg"); | ||
| const { AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY } = process.env; |
There was a problem hiding this comment.
Does it mean that you don't need to store them in .env?
There was a problem hiding this comment.
Yep - or provide them to the process on the command-line, but the dotenv.config() above helps load them from a file.
elle-j
approved these changes
Dec 5, 2023
| }; | ||
|
|
||
| function assertImage(value: unknown): asserts value is Image { | ||
| assert(typeof value === "object" && value !== null); |
There was a problem hiding this comment.
Suggested change
| assert(typeof value === "object" && value !== null); | |
| assert(typeof value === "object" && value !== null && !Array.isArray(value)); |
There was a problem hiding this comment.
I think it's fine. Without the explicit check for array, the property checks below will return undefined and fail their assertions.
| }; | ||
|
|
||
| function assertImagesResponse(value: unknown): asserts value is ImagesResponse { | ||
| assert(typeof value === "object" && value !== null); |
There was a problem hiding this comment.
Suggested change
| assert(typeof value === "object" && value !== null); | |
| assert(typeof value === "object" && value !== null && !Array.isArray(value)); |
| const object = value as Record<string, unknown>; | ||
| assert(Array.isArray(object.allBranches)); | ||
| const { images } = object; | ||
| assert(typeof images === "object" && images !== null); |
There was a problem hiding this comment.
Suggested change
| assert(typeof images === "object" && images !== null); | |
| assert(typeof images === "object" && images !== null && !Array.isArray(images)); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We still need to update the instructions for how to get the AWS credentials, but with this PR the BaaS test server will be pulled from AWS ECR and will run in an Arm64 compatible docker container 🎉