Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add --follow flag to logs command (#729) #731

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(cli): add --follow flag to logs command (#729) #731

merged 1 commit into from
Oct 21, 2024

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Sep 27, 2024 •
edited
Loading

Closes #730

Old code is moved to retrieve_workflow_logs function, log following implemented in follow_workflow_logs.

Added test for the command (both retrieval and following).

jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 27, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
e1773a9
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from aaaf7e4 to e1773a9 Compare September 27, 2024 15:42
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
3327a56
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from e1773a9 to 3327a56 Compare September 30, 2024 08:42
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
90a9109
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 3327a56 to 90a9109 Compare September 30, 2024 08:44
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
08913d3
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 90a9109 to 08913d3 Compare September 30, 2024 12:30
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
18e3052
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 08913d3 to 18e3052 Compare September 30, 2024 12:33
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Sep 30, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
1094750
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 18e3052 to 1094750 Compare September 30, 2024 12:35
@jlemesh jlemesh mentioned this pull request Oct 1, 2024
Merged
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 10, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
ab17590
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 1094750 to ab17590 Compare October 10, 2024 13:24
tiborsimko
tiborsimko reviewed Oct 14, 2024
View reviewed changes
reana_client/cli/utils.py Show resolved Hide resolved
reana_client/cli/workflow.py Outdated Show resolved Hide resolved
reana_client/cli/workflow.py Outdated Show resolved Hide resolved
reana_client/cli/workflow.py Show resolved Hide resolved
reana_client/cli/utils.py Outdated Show resolved Hide resolved
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
7993bbf
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from ab17590 to 7993bbf Compare October 14, 2024 15:38
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
81d36fd
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 7993bbf to 81d36fd Compare October 14, 2024 15:39
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 14, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
bfff557
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 81d36fd to bfff557 Compare October 14, 2024 15:44
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 15, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
a9ef8dc
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from bfff557 to a9ef8dc Compare October 15, 2024 08:47
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 15, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
68fcaae
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from a9ef8dc to 68fcaae Compare October 15, 2024 08:51
@jlemesh jlemesh mentioned this pull request Oct 15, 2024
Merged
jlemesh added a commit to jlemesh/reana-client that referenced this pull request Oct 17, 2024
@jlemesh
feat(cli): add --follow flag to logs command (reanahub#731)
9ba012f
@jlemesh jlemesh force-pushed the feature_add_logs_follow_cmd branch from 68fcaae to 9ba012f Compare October 17, 2024 10:57
@tiborsimko tiborsimko force-pushed the feature_add_logs_follow_cmd branch from 9ba012f to dda80d1 Compare October 21, 2024 13:58
tiborsimko
tiborsimko approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works nicely 👍

I have fixed the docstring typo and amended commitlint scope.

@tiborsimko tiborsimko merged commit dda80d1 into reanahub:master Oct 21, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko tiborsimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: display live logs
2 participants
@jlemesh @tiborsimko