Skip to content

Commit

Permalink
fix(reana-dev): use chore commit scope when bumping dependencies (#868)
Browse files Browse the repository at this point in the history
For commits created by `reana-dev git-upgrade-shared-modules` and
`reana-dev git-upgrade-requirements` commands, use "chore" rather than
"build" conventional commit scope, so that these commits won't appear in
the release news message.

The bug fixes or new features that are brought by upgrades are announced
in the release news in another way, such as when a feature needs the new
shared package or an upgraded version of dependency. The pre-release
version bumps can therefore go without a release news item.
  • Loading branch information
tiborsimko committed Feb 3, 2025
1 parent 8acfb28 commit 3788789
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions reana/reana_dev/git.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
#
# This file is part of REANA.
# Copyright (C) 2020, 2021, 2023, 2024 CERN.
# Copyright (C) 2020, 2021, 2023, 2024, 2025 CERN.
#
# REANA is free software; you can redistribute it and/or modify it
# under the terms of the MIT License; see LICENSE file for more details.
Expand Down Expand Up @@ -1296,7 +1296,7 @@ def git_upgrade_shared_modules(
def _create_commit_or_amend(components):
today = datetime.date.today().isoformat()
for c in components:
commit_cmd = f'git commit -m "build(python): bump shared REANA packages as of {today}{get_commit_pr_suffix(c)}"'
commit_cmd = f'git commit -m "chore(master): bump shared REANA packages as of {today}{get_commit_pr_suffix(c)}"'

Check warning on line 1299 in reana/reana_dev/git.py

View check run for this annotation

Codecov / codecov/patch

reana/reana_dev/git.py#L1299

Added line #L1299 was not covered by tests
if amend:
commit_cmd = "git commit --amend --no-edit"

Expand Down Expand Up @@ -1382,7 +1382,7 @@ def git_upgrade_requirements(ctx, component, exclude_components): # noqa: D301
run_command(f"git add {PYTHON_REQUIREMENTS_FILE}", component)
today = datetime.date.today().isoformat()
run_command(
f'git commit -m "build(python): bump all required packages as of {today}{get_commit_pr_suffix(component)}"',
f'git commit -m "chore(master): bump all required packages as of {today}{get_commit_pr_suffix(component)}"',
component,
)

Expand Down

0 comments on commit 3788789

Please sign in to comment.