helm: expose optional workspace paths while deploying the cluster #533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
+ Coverage 14.96% 15.04% +0.07%
==========================================
Files 17 17
Lines 1530 1529 -1
==========================================
+ Hits 229 230 +1
+ Misses 1301 1299 -2
|
reana/reana_dev/cluster.py
Outdated
| @@ -236,7 +236,7 @@ def cluster_build( | |||
| "--workspace-mounts", | |||
| multiple=True, | |||
| help="Which directories from the Kubernetes nodes to mount inside the cluster pods? " | |||
| "cluster_node_path:job_pod_mountpath, e.g /var/reana/mydata:/mydata", | |||
| "cluster_node_path:cluster_pod_mountpath, e.g /var/reana/mydata:/mydata", | |||
There was a problem hiding this comment.
Can you explain why this was needed? /mydata is job_pod_mountpath
There was a problem hiding this comment.
But this paths are mounted not only for the jobs, but also for cluster pods r-w-controller and reana-server. I thought that job_pod_mountpath was not completely correct (but cluster_pod_mountpath might also not be correct, as is not for all cluster pods.....).
marcdiazsan
force-pushed
the
workspace-options
branch
from
b30b207 to
7d8d7c0
Compare
marcdiazsan
force-pushed
the
workspace-options
branch
from
7d8d7c0 to
278acd1
Compare
There was a problem hiding this comment.
Works nicely!
Edit:
Rebase is missing. Can you also squash some of the commits?
I guess a list of cluster paths is not enough for all the cases, since for example /eos host path is /var/eos in Kubernetes nodes. We need a way to specify cluster_node_path:job_pod_mountpath pairs for a workspace path list, similarly to what was done here. Probably could be fixed in another PR?
marcdiazsan
force-pushed
the
workspace-options
branch
from
1231394 to
a3ccc09
Compare
marcdiazsan
force-pushed
the
workspace-options
branch
from
a3ccc09 to
50c3d22
Compare
Closes #532