Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.12.1.1 #1432

Merged
merged 33 commits into from
Dec 7, 2020
Merged

Version 2.12.1.1 #1432

merged 33 commits into from
Dec 7, 2020

Conversation

cfillion
Copy link
Member

@cfillion cfillion commented Oct 22, 2020

Preparing a hotfix update to 2.12.1. EDIT: Promoting that to a full bugfix update given the recent PRs. EDIT2: Reverting back to hotfix (+ trivial PRs) for quicker stable adoption.


v2.12.1.1 pre-release build

Accessibility:

  • Support OSARA's shortcut help mode in cycle, continuous and MIDI editor actions

macOS:

  • Add macOS ARM64 build
  • Fix NF Eraser tool cursor not appearing (report here)

MIDI:

  • Fix MIDI CC shape loss after running any of the following actions (REAPER v6+ only, issue 1466):
    • SWS/BR: Delete tempo marker and preserve position and length of items (including MIDI events)
    • SWS/BR: Delete tempo marker and preserve position and length of selected items (including MIDI events)
    • SWS/BR: Enable "Ignore project tempo" for selected MIDI items preserving time position of MIDI events (use tempo at item's start)
  • Fix FNG MIDI actions treating only the first selected item in REAPER v6 (regression from v2.12.1, issue 1429)

Miscellaneous:

  • Fix SWS/AW: Paste not setting the time selection when "Trim contents behind media items when editing" is enabled (regression from v2.11)
  • Obey the "Move edit cursor when pasting/inserting media" preference in SWS/AW: Paste even when "Trim contents behind media items when editing" is disabled

ReaScript API:

  • Deprecate BR_GetMediaTrackGUID (use GetSetMediaTrackInfo_String from REAPER instead)
  • Deprecate ULT_GetMediaItemNote and ULT_SetMediaItemNote (use GetSetMediaItemInfo_String instead)
  • Fix fetching tracks from background project tabs using BR_GetMediaTrackByGUID
  • Fix generation of sws_python64.py
  • Preserve existing edges when passing negative values to BR_SetItemEdges (issue 1114)
  • Prevent NF_AnalyzeTakeLoudness's progress popup from stealing focus from other apps (report here)
  • Remove NF_ReadID3v2Tag (use GetMediaFileMetadata from REAPER instead)

@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

@cfillion cfillion changed the title Version 2.12.1.1 Version 2.12.2 Nov 15, 2020
nofishonfriday and others added 5 commits November 17, 2020 00:07
…or actions

Inhibit execution of SWS cycle, continuous and MIDI editor actions when OSARA's shortcut help mode is enabled and OSARA was loaded after SWS.

See jcsteh/osara#359.
Fixes CC shape loss after running the following actions (R6+ only):

- SWS/BR: Delete tempo marker and preserve position and length of items (including MIDI events)
- SWS/BR: Delete tempo marker and preserve position and length of selected items (including MIDI events)
- SWS/BR: Enable "Ignore project tempo" for selected MIDI items preserving time position of MIDI events (use tempo at item's start)

Reported at https://forum.cockos.com/showpost.php?p=2368423, fixes #1466
@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Nov 30, 2020

@cfillion Given that the reports about already fixed but not yet officially released issues seem to accumulate (e.g. here and here), how about making this PR into the next official release (soonish) and then continue working on the next beta?
I fear a little that if we're trying to release a 'bug free' major version it'll 'never happen'. :D

What do you think?

REAPER v6.17+dev1130 adds native API function GetMediaFileMetadata()
@cfillion
Copy link
Member Author

cfillion commented Dec 1, 2020

I'd like to include some of the newer bugfixes too. The python64 one is major and the tag API must be removed before going stable. Then many PRs seem trivial enough to be low-risk: continuation of R6 CC shape support, the OSARA one, eraser tool cursor, track GUID.

To go stable faster I'm thinking of leaving the riskier cycle action PRs for a later release.

@cfillion cfillion changed the title Version 2.12.2 Version 2.12.1.1 Dec 5, 2020
@AppVeyorBot

This comment has been minimized.

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Dec 5, 2020

whatsnew nitpick:

Support OSARA's shortcut help mode in cycle, continuous and MIDI editor actions

could say:

Accessibility: support...

(similar to the Reaper whatsnew entries related to accessibility topics)

REAPER v5.95 added GetSetMediaItemInfo_String with read/write access to P_NOTES.
@AppVeyorBot

This comment has been minimized.

@AppVeyorBot

This comment has been minimized.

…s behind media items when editing" is enabled

Regression from 2.11 due to a typo (c06f8cf)
…using SWS/AW: Paste

...and "Trim contents behind media items when editing" is disabled

Older versions disabled that preference (not restoring the original value unless trim is enabled). This was accidentally fixed in 2.11.
@cfillion
Copy link
Member Author

cfillion commented Dec 6, 2020

Planning to release this tomorrow.

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Dec 6, 2020

What do you think about adding #1444?
It's a fix and seems rather risk free low-risk (at first glance)?

Otherwise, thumbs up!

@cfillion
Copy link
Member Author

cfillion commented Dec 6, 2020

What do you think about adding #1444?

Changing the meaning of "selected FX" from "the last FX shown in the chain" to "all selected FXs in the chain" makes me a bit hesitant (it's a big change). Only one action gets the new meaning, making it inconsistent with all other SWS actions dealing with "selected FX". I wrote some comments at #1443 (comment).

@cfillion cfillion merged commit 3ea0807 into master Dec 7, 2020
@cfillion cfillion deleted the v2.12.1.1 branch December 7, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants