Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store refmt as a CircleCI artifact #2462

Closed

Conversation

Schniz
Copy link

@Schniz Schniz commented Oct 8, 2019

This commit is for being able to download latest refmt on CI without installing and compiling OCaml and the reason package, as I mentioned in Schniz/fnm#151

I'm not quite sure that it'll work, since I can't really test the CI
locally. but I have high hopes!

This commit is for being able to download latest `refmt` on CI without
installing and compiling OCaml and the `reason` package.
@jordwalke
Copy link
Member

CircleCI CI is likely going to be deprecated now that we have azure all figured out. I recently made some changes where every commit will publish a reason-cli artifact on azure.

You can check it out here for the latest master commit:
https://dev.azure.com/reasonml/reason/_build/results?buildId=403&view=artifacts

There's a .tgz file in the Release section which can be installed and gives refmt and rtop.

We could create another release that just has refmt so that it would be lighter weight.

Also, I learned we can make platform specific releases so that the total package size will be much less. Instead of bundling them all into one, we can use optionalDependencies: https://stackoverflow.com/questions/15176082/npm-package-json-os-specific-dependency/26069595

@Schniz
Copy link
Author

Schniz commented Nov 27, 2019

Alright! I made a GH action that uses the latest version of reason using Azure — https://github.com/Schniz/fnm/pull/152/checks?check_run_id=322770191

I'm not sure that it's good though, because I'm not sure you can look for a specific git tag (if this is how we'll do versioning) and how long will the artifact be stored in Azure.

I think we can also make a smaller artifact, that will just have the .tgz file and then it'll be faster to download. It takes 1m:36s to download that huge >1gb zip file when we only need the .tgz release file

what do you think?

@davesnx
Copy link
Member

davesnx commented Mar 28, 2023

This is not needed anymore, but would be nice to push refmt as GH releases instead

@davesnx davesnx closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants