Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom scales and decimals to be set for DataSize #84

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DataSize unit and number of decimal places are set and cannot be configured by the user

Issue Number: N/A

What is the new behavior?

Allows custom scale and decimal to be passed into the component

image

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@steppy452 steppy452 requested a review from amcdnl November 16, 2023 03:27
@steppy452 steppy452 force-pushed the syang/data-size-customizations branch from eb81bcf to a61a7ad Compare November 16, 2023 03:37
@amcdnl amcdnl merged commit 5e7d21b into master Nov 16, 2023
@amcdnl amcdnl deleted the syang/data-size-customizations branch November 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants