Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize colors for disabled toggle #87

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

evgenoid
Copy link
Contributor

@evgenoid evgenoid commented Dec 8, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No ability to customize colors for disabled Toggle

What is the new behavior?

Added ability to customize colors for disabled Toggle

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@evgenoid evgenoid requested a review from amcdnl December 8, 2023 08:58
@evgenoid evgenoid self-assigned this Dec 8, 2023
Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks required

@amcdnl
Copy link
Member

amcdnl commented Dec 8, 2023

Need to update docs too.

@evgenoid
Copy link
Contributor Author

evgenoid commented Dec 8, 2023

Need to update docs too.

Done

@evgenoid evgenoid requested a review from amcdnl December 8, 2023 12:44
Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to update the Toggle.mdx

@evgenoid
Copy link
Contributor Author

evgenoid commented Dec 8, 2023

also need to update the Toggle.mdx

Done

@evgenoid evgenoid requested a review from amcdnl December 8, 2023 12:51
@@ -1,9 +1,4 @@
.switch {
/** TODO: Improve this sizing logic */
--toggle-width: 55px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgenoid - Should we make these defaults too ?

@evgenoid evgenoid requested a review from amcdnl December 8, 2023 13:04
@amcdnl amcdnl merged commit 696fc9e into master Dec 8, 2023
1 check passed
@amcdnl amcdnl deleted the feature/toggle-disabled-colors branch December 8, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants