Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you place RangeSingle in a parent element with some affected positioning the drag gets messed up
What is the new behavior?
You can place RangeSingle in any parent element
Does this PR introduce a breaking change?
Other information
This sets the range left offset relative to the viewport instead of the parent element
It needs to be based off viewport to align with the pointer clientX being used to calc the handle position
This shouldn't be a breaking change, but it feels like it could depending if people have done some hacky solutions to avoid this problem
BEFORE
Screen.Recording.2023-12-29.at.11.25.12.AM.mov
AFTER
Screen.Recording.2023-12-29.at.11.25.50.AM.mov
Also story still works as expected without added div wrapper
Screen.Recording.2023-12-29.at.11.41.24.AM.mov