feat(DRM): License URL support for Extensions #1432
+153
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Dec 29, 2024
|
This will also be blocked until stable like #1216 |
We can go the other approach extending DrmExtractorLink and based on the existence of keyUrl will setup Media3 configuration online/offline |
KingLucius
force-pushed
the
widevineSupport
branch
from
2067171 to
18ad431
Compare
| keyRequestParameters: HashMap<String, String> = hashMapOf(), | ||
| licenseUrl: String? = null, |
There was a problem hiding this comment.
This will break the API, so this will be blocked until stable.
There was a problem hiding this comment.
I saw that if we are going to wait stable anyway, I can add the parameter like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions developers can use OnlineDrmExtractorLink to provide the Drm license URL.