Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviews support #1534

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Add reviews support #1534

wants to merge 36 commits into from

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Feb 1, 2025

TODO:

  • TV UI
  • Improve rating format handling
  • Improve spoiler handling

@Luna712
Copy link
Contributor Author

Luna712 commented Feb 1, 2025

This has been fully tested to work on mobile, still need to add UI for TV though.

@Luna712 Luna712 changed the title Add reviews support to API Add reviews support Feb 1, 2025
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only a reviewed the code itself for API changes, and did not test it. You will get a tested review after the draft period. Keep in mind that the mainapi has very strict requirements as it is hard to change after introducing it.

open suspend fun loadReviews(
url: String,
page: Int,
showSpoilers: Boolean = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this api might be functional, we might want to also add sort by or filter by.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave spoiler support control to the API so it is no longer done here at all, can pass isSpoiler to UserReview and then it has a UI for spoilers (which will be improved) as for sort I guess we could add it if you think we need to?

url: String,
page: Int,
showSpoilers: Boolean = false
): List<UserReview> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike HomePageResponse, this lacks a hasNext making it hard to know if we should re-fetch or not if it fails.

@Luna712
Copy link
Contributor Author

Luna712 commented Feb 5, 2025

I put this on hold for now. I am go back to it eventually but this has become much more work than I originally bargained for...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants