Fix typos in unimplimented methods in MainAPI #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luna712
changed the title
fire-light42
requested changes
Feb 11, 2025
| this.addSimklId(SimklSyncServices.Imdb, id) | ||
| } | ||
|
|
||
| @Suppress("UNUSED_PARAMETER") | ||
| fun LoadResponse.addTrackId(id: String?) { | ||
| // TODO add trackt sync | ||
| fun LoadResponse.addTraktId(id: String?) { |
There was a problem hiding this comment.
While this might seam like an easy fix, it is not. Modifying the api means that until a new stable, either stable or pre is going to crash, even if the implementation is empty. To fix this, please add back the old functions too, but mark them as @Deprecated("Outdated API", ReplaceWith("addTraktId(id)")), and make them call the new functions.
There was a problem hiding this comment.
Dont forget @Prerelease tag. Or instead add @JvmName("oldjvmnamehere").
There was a problem hiding this comment.
Oh right thanks. Good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.