Feature: episode sort button #1565
Open
+216
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sort button next to episode count - Implement ascending/descending episode sort toggle - Add sort direction indicator (▲/▼) to button text - Make sort button visible when episodes are loaded - Position sort button after episode count text
- Only show rating sort options when episodes have rating data - Only show air date sort options when episodes have air date data - Episode number sorting always available - Improved sort button text to reflect available options - Fallback to episode sorting when selected sort data unavailable
CranberrySoup
suggested changes
Feb 21, 2025
fire-light42
requested changes
Feb 22, 2025
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
- Remove usage of requireContext() and requireActivity() - Use safe context handling with view.context - Consolidate string resources using format arguments - Add null safety checks for activity and context - Remove redundant dialog configuration - Improve sort options handling with conditional visibility - Fix dialog showing logic - Add empty list check to disable sort options when no episodes
Yes it does not support TV, ill send a new PR for TV, having trouble getting the extensions installed on emulator TV |
|
Worked well when testing, however we might want to
|
- Set sort button to always appear at the end of its row - Add proper margin spacing to sort button and episodes text - Use FlexboxLayout's justifyContent and layout_order attributes - Ensure consistent margins across UI elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Sort Button with Existing Theming
Fixes #958 #1069
This PR introduces a Sort Button that allows users to sort episodes based on different criteria. By default, it displays sorting options for episode number (ascending/descending) and, if available, rating and air date.
Key Changes:
• Added a Sort Button to trigger the sorting dialog.
• Uses the same styling as the existing Season Selection Dialog (AlertDialogCustom).
• Ensures sorting options include:
• Episode Number (Asc/Desc) - Always available
• Rating (High-Low / Low-High) - Only if episodes have ratings
• Air Date (Newest-Oldest / Oldest-Newest) - Only if episodes have air dates
This change maintains UI consistency while improving the sorting functionality.