Skip to content

Commit

Permalink
test postal code japan: modify the downloaded URL (#180)
Browse files Browse the repository at this point in the history
Rationale for this change
---

Unable to download `ken_all_rome.zip` for the test of postal code in
Japan because the downloaded URL is `ken_all_rome.zip`, not
`KEN_ALL_ROME.zip`. It has been modified below.

https://www.post.japanpost.jp/zipcode/dl/roman-zip.html

What changes are included
---

Modify the downloaded URL.
  • Loading branch information
tikkss authored Nov 15, 2023
1 parent 22cbc3b commit 48749eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/datasets/postal-code-japan.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def open_data
when :uppercase
data_url << "/oogaki/zip/ken_all.zip"
when :romaji
data_url << "/roman/ken_all_rome.zip"
data_url << "/roman/KEN_ALL_ROME.zip"
end
data_path = cache_dir_path + "#{@reading}-ken-all.zip"
download(data_path, data_url)
Expand Down

0 comments on commit 48749eb

Please sign in to comment.