Update thrift to v0.21.0 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
mathyourlife-reddit
and removed request for
a team
mathyourlife-reddit
approved these changes
Sep 23, 2024
fishy
force-pushed
the
thrift-0.21.0
branch
from
3ba6f2d to
6e18069
Compare
Also rerun thrift compiler v0.21.0 on baseplate.thrift. Also add thriftbp.ClientPoolConfig.UseZlib, which was not possible before.
fishy
force-pushed
the
thrift-0.21.0
branch
from
6e18069 to
1ea06f5
Compare
kylelemons
approved these changes
Sep 23, 2024
| @@ -228,6 +228,12 @@ type ClientPoolConfig struct { | |||
| // | |||
| // Optional. If empty, no "thrift-hostname" header will be sent. | |||
| ThriftHostnameHeader string `yaml:"thriftHostnameHeader"` | |||
|
|
|||
| // Uses zlib transform in thrift THeader connections between client and | |||
There was a problem hiding this comment.
is THeader just for headers, or for the whole connection? UseZlib sounds like this is for the whole connection, but the docs make it sound like it's just for headers...
so maybe
- rename to
UseZlibForHeaders, or - update the comment to specify that this is for the whole connection
?
There was a problem hiding this comment.
THeader is a thrift TProtocol/TTransport (it's just the only TProtocol/TTransport that supports headers, thus the name)
so it's for the whole connection.
konradreiche
approved these changes
Sep 23, 2024
konradreiche
approved these changes
Sep 23, 2024
mathyourlife-reddit
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rerun thrift compiler v0.21.0 on baseplate.thrift.
Also add thriftbp.ClientPoolConfig.UseZlib, which was not possible before.