Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVAI-196: Helm Chart Linting #30

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Jan 16, 2025

What does this PR do?:

This pull request adds the chart-testing tool and github action to this repository.

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/RHDHPAI-74

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified
  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

@coreydaley coreydaley force-pushed the 2025-01-16-complete-helm-chart-testing branch from 05847b4 to 9024fb5 Compare January 16, 2025 20:50
@coreydaley coreydaley changed the title [WIP] DEVAI-196: Helm Chart Testing [WIP] DEVAI-196: Helm Chart Linting Jan 16, 2025
@coreydaley coreydaley force-pushed the 2025-01-16-complete-helm-chart-testing branch 2 times, most recently from c954b6e to 0a00ad9 Compare January 17, 2025 17:01
@coreydaley coreydaley force-pushed the 2025-01-16-complete-helm-chart-testing branch from 0a00ad9 to 0d4277b Compare January 17, 2025 17:03
@coreydaley coreydaley changed the title [WIP] DEVAI-196: Helm Chart Linting DEVAI-196: Helm Chart Linting Jan 17, 2025
Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coreydaley coreydaley merged commit e14adc1 into redhat-ai-dev:main Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants