-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role/deploy_flask_app - change required parameter key pair with path to ssh key file #109
role/deploy_flask_app - change required parameter key pair with path to ssh key file #109
Conversation
3bee293
to
0e09fe5
Compare
0b901fb
to
4ad3c54
Compare
changelogs/fragments/20231219-deploy_flask_app-update-arguments-spec.yml
Outdated
Show resolved
Hide resolved
For |
@GomathiselviS the playbook |
- name: Webapp HA | ||
hosts: aurora | ||
gather_facts: false | ||
strategy: free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this prevents tasks from prematurely aborting on encountering a failure on one of the hosts. However, this may not be convenient when debugging the failure.
I am unable to run webapp_ha_aurora.yaml. It fails with
|
@GomathiselviS It is failing because you did not execute from scratch, try to clean everything and run again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything functions properly except for the addition of two variables in the vars file.
Co-authored-by: GomathiselviS <[email protected]>
Fixes #103
The integration test
test_deploy_flask_app
(along with the following playbookswebapp/migrate_webapp
,webapp/webapp
,webapp/webapp_ha_aurora
) are failing because the roledeploy_flask_app
was expecting a key pair name to ssh-connect to the bastion while it should expected theprivate key file
.This fix replaces the corresponding parameter
deploy_flask_app_sshkey_pair_name
defining the key pair name by the new onedeploy_flask_app_bastion_ssh_private_key
defining the path to the private key fileThe integration test is also facing some time out, to reduce the execution time the bastion host will be created with user_data provided in order to boot the virtual machine directly with the required packages. This change has been done in the following file
playbooks/webapp/tasks/create.yaml
impacting the playbookswebapp
,webapp_ha_aurora
The deletion operation of the playbook
playbook/webapp/webapp
was missing some resources to be deleted in order to be successful, this has been correctedThe playbook to deploy has been simplified to faster the execution. We do not need anymore to create a local registry server from the bastion host to pull images on worker. The webapp image is directly pulled from public docker registry
docker.io