Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security for keypair creation in configure_ec2 pattern #129

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

GomathiselviS
Copy link
Contributor

Refer : https://issues.redhat.com/browse/ACA-2059
This PR ensures that private keys to ec2 instances are not available in job logs by default

@GomathiselviS GomathiselviS changed the title Add security for keypair creation in configure_ec2 pattern WIP: Add security for keypair creation in configure_ec2 pattern Dec 12, 2024
@GomathiselviS GomathiselviS changed the title WIP: Add security for keypair creation in configure_ec2 pattern Add security for keypair creation in configure_ec2 pattern Dec 13, 2024
@@ -4,6 +4,18 @@

This pattern is designed to help get an EC2 instance up and running.

To enable SSH access to the EC2 instance from your local machine, you need to do 2 things:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To enable SSH access to the EC2 instance from your local machine, you need to do 2 things:
To enable SSH access to the EC2 instance from your local machine, following 2 actions are required:

@GomathiselviS GomathiselviS merged commit c7c6737 into redhat-cop:main Dec 13, 2024
26 checks passed
Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply c7c6737 on top of patchback/backports/stable-3/c7c6737a2a2695198185a7e4450c58d60ea4def8/pr-129

Backporting merged PR #129 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/redhat-cop/cloud.aws_ops.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-3/c7c6737a2a2695198185a7e4450c58d60ea4def8/pr-129 upstream/stable-3
  4. Now, cherry-pick PR Add security for keypair creation in configure_ec2 pattern #129 contents into that branch:
    $ git cherry-pick -x c7c6737a2a2695198185a7e4450c58d60ea4def8
    If it'll yell at you with something like fatal: Commit c7c6737a2a2695198185a7e4450c58d60ea4def8 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x c7c6737a2a2695198185a7e4450c58d60ea4def8
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add security for keypair creation in configure_ec2 pattern #129 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-3/c7c6737a2a2695198185a7e4450c58d60ea4def8/pr-129
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/c7c6737a2a2695198185a7e4450c58d60ea4def8/pr-129

Backported as #145

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 24, 2025
Add security for keypair creation in configure_ec2 pattern

(cherry picked from commit c7c6737)
abikouo added a commit that referenced this pull request Jan 24, 2025
…c7c6737a2a2695198185a7e4450c58d60ea4def8/pr-129

[PR #129/c7c6737a backport][stable-3] Add security for keypair creation in configure_ec2 pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants