added pr testing and scorecard #80
Conversation
|
resolved comments |
|
@sabre1041 good to merge? or want anything else changed? |
|
@sabre1041 good to merge? |
|
gareth, I think theres's value to this PR. How hard would it be to test against multiple repos? A sort of running this a matrix of repos. |
|
@raffaelespazzoli ; i can look to do that, not sure when I will have time (maybe in a few weeks), so can we get this PR merged? and then I'll do that suggestion on another PR. |
|
@garethahealy we have a things we want to clear with our operators first. then we can look to integrate this PR in |
garethahealy
force-pushed
the
main
branch
5 times, most recently
from
3e9b0d7 to
625385f
Compare
| - name: Check out code | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 | ||
| with: | ||
| repository: ${{ inputs.CHECKOUT_CODE }} |
There was a problem hiding this comment.
moved checkout further up the stack due to variable setting paths
| run: | | ||
| echo "repository_name=$(basename $GITHUB_REPOSITORY)" >> $GITHUB_OUTPUT | ||
| echo "repository_name=$(basename ${{ env.CHECKOUT_CODE }})" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
needs to be the repo we are actually working against, not what github checked out for us (i.e.: this one)
| @@ -479,7 +497,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| # Render Helm Chart | |||
| make helmchart VERSION=${{ env.HELM_RELEASE_VERSION }} IMG=${{ env.OPERATOR_IMAGE_REPOSITORY }}:${{ env.OPERATOR_VERSION }} | |||
| make helmchart OPERATOR_NAME=${{ env.REPOSITORY_NAME }} VERSION=${{ env.HELM_RELEASE_VERSION }} IMG=${{ env.OPERATOR_IMAGE_REPOSITORY }}:${{ env.OPERATOR_VERSION }} | |||
There was a problem hiding this comment.
OPERATOR_NAME defaults to pwd but thats wrong when testing. so supply the name which is resolved in the setup
|
@sabre1041 @raffaelespazzoli added tests for several repos as requested and comments explaining changes |
| @@ -0,0 +1,24 @@ | |||
| name: Testing group-sync-operator | |||
| on: | |||
There was a problem hiding this comment.
action file per test is needed to stop conflicts from the upload action
Any PRs to the workflows in this repo have to be manually tested outside of the repo. I've done this by changing a consumer repo (i.e.: redhat-cop/group-sync-operator) to use the new version of my fork.
This change adds the ability to run the PR workflow against
redhat-cop/group-sync-operator, improving confidence any changes to the PR workflow are OK and will at least work againstredhat-cop/group-sync-operatorThe new
inputis to allow the workflow to work against another repo, since this one doesn't contain any code.