Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build against 2023.1 for constructor compatibility (#823) #825

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: build against 2023.1 for constructor compatibility (#823) #825

merged 1 commit into from
Jan 31, 2025

Conversation

adietish
Copy link
Collaborator

fixes #823

@adietish adietish self-assigned this Jan 30, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adietish adietish requested a review from sbouchet January 30, 2025 22:16
@adietish
Copy link
Collaborator Author

adietish commented Jan 30, 2025 •
edited
Loading

@sbouchet: Built against IC-2023.1, the oldest compatible version. No compatibility problems reported any more. Please review.

@adietish adietish marked this pull request as ready for review January 30, 2025 22:18
sbouchet
sbouchet approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should make it !

@adietish adietish merged commit a374bca into redhat-developer:main Jan 31, 2025
9 checks passed
@adietish adietish deleted the issue-823 branch January 31, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix compatibility problems with IC-2031 - IC-2024.2 reported by the marketplace
2 participants
@adietish @sbouchet