Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GroupOwnershipResolver and config name #2366

Merged

Conversation

JessicaJHee
Copy link
Member

Description

Transitive fits better in this case because group hierarchical relationships are persistent.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Feb 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JessicaJHee JessicaJHee marked this pull request as ready for review February 12, 2025 16:15
@JessicaJHee JessicaJHee changed the title update GroupOwnershipResolver and config name chore: update GroupOwnershipResolver and config name Feb 12, 2025
Copy link
Contributor

@kim-tsao
Copy link
Member

/lgtm

@kim-tsao
Copy link
Member

/cherrypick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2025
Copy link
Contributor

@JessicaJHee
Copy link
Member Author

/retest

@kim-tsao
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7b79d5e into redhat-developer:main Feb 12, 2025
12 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@kim-tsao: new pull request created: #2370

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants