Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with all supported Rails versions #53 #115

Merged
merged 12 commits into from
Nov 26, 2024
Merged

Test with all supported Rails versions #53 #115

merged 12 commits into from
Nov 26, 2024

Conversation

n-rodriguez
Copy link
Contributor

@n-rodriguez n-rodriguez commented Nov 12, 2024

Hi there!

I've updated CI config to be in line with https://github.com/redis-store/redis-actionpack and to add support for Rails 8 but while doing this I realized that this gem depends on https://github.com/redis-store/redis-activesupport which is now archived.

I think this gem can also be archived since it's blocked by https://github.com/redis-store/redis-activesupport/blob/master/redis-activesupport.gemspec#L22.

Thank you!

@n-rodriguez n-rodriguez requested a review from tubbo as a code owner November 12, 2024 13:07
@n-rodriguez
Copy link
Contributor Author

ping @tubbo

@tubbo
Copy link
Contributor

tubbo commented Nov 26, 2024

my bad for the holdup guys merging this now

@tubbo tubbo merged commit b6a9c2b into redis-store:master Nov 26, 2024
34 checks passed
@n-rodriguez n-rodriguez deleted the wip/rails8 branch November 28, 2024 15:36
@n-rodriguez
Copy link
Contributor Author

No worries, thank you! 👍

@mpvosseller
Copy link

Any idea when this might get released? Thank you so much for the work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants