-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4815 added candidate AMR connection page #1136
base: main
Are you sure you want to change the base?
Conversation
from redis_entraid.cred_provider import * | ||
|
||
credential_provider = create_from_managed_identity( | ||
identity_type=ManagedIdentityType.USER_ASSIGNED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use ManagedIdentityType.SYSTEM_ASSIGNED
as an example. System-assigned method requires no additional inputs, however User-assigned requires at least id_type
and id_type
argument, so System-assigned is better for the most basic use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
Thanks @cmilesb and @vladvildanov ! |
DOC-4815
Note: this isn't anywhere near final yet - it's just a suggestion for a possible format for the AMR client docs. A few things to consider:
Any other feedback, suggestion, etc, are very welcome :-)