fix: do not return repeated directly #1605
Conversation
Use the complete response when the response is a list Signed-off-by: Santiago Jimenez Giraldo <[email protected]>
|
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
|
Generally I agree with this. See https://google.aip.dev/132. |
| get: "/v1alpha2/topics/{topic_name}/configurations" | ||
| response_body: "configurations" | ||
| }; | ||
| option (google.api.http) = {get: "/v1alpha2/topics/{topic_name}/configurations"}; |
There was a problem hiding this comment.
Should we do it, despite knowing the number of entries is very limited and will never exceed an unreasonable number that couldn't be retrieved in one go? The AIP-132 seems to suggest that. I guess we'll follow then
| @@ -292,10 +292,7 @@ service TopicService { | |||
| }; | |||
| } | |||
| rpc GetTopicConfigurations(GetTopicConfigurationsRequest) returns (GetTopicConfigurationsResponse) { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good observation. Maybe ListTopicConfigurations() is a better choice. Agree it kinda depends on how you look at it. But I do not feel strongly about it.
Use the complete response when the response is a list.
for some method the example does not match the actual response and we probably want to ensure the response is not nested. maybe the question is around breaking the API, so happy to do it for V1