Skip to content

Commit

Permalink
kafka: Describe 'allow_gaps' config
Browse files Browse the repository at this point in the history
Signed-off-by: Evgeny Lazin <[email protected]>
  • Loading branch information
Lazin committed Jan 21, 2025
1 parent 00793ba commit eb85d6a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/v/kafka/server/handlers/configs/config_response_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,19 @@ config_response_container_t make_topic_configs(
"topic."),
&describe_as_string<bool>);

add_topic_config_if_requested(
config_keys,
result,
topic_property_remote_allow_gaps,
false,
topic_property_remote_allow_gaps,
topic_properties.remote_topic_allow_gaps,
include_synonyms,
maybe_make_documentation(
include_documentation,
"Allow offset gaps if the Tiered-Storage is paused."),
&describe_as_string<bool>);

return result;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/rptest/tests/describe_topics_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,12 @@ def test_describe_topics_with_documentation_and_types(self):
doc_string=
"If true, delete the corresponding Iceberg table when deleting the topic."
),
"redpanda.remote.allow_gaps":
ConfigProperty(
config_type="BOOLEAN",
value="false",
doc_string="Allow offset gaps if the Tiered-Storage is paused."
),
}

tp_spec = TopicSpec()
Expand Down

0 comments on commit eb85d6a

Please sign in to comment.