Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: build tests with bazel #24715

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jan 7, 2025

storage: build tests with bazel

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@rockwotj
Copy link
Contributor

rockwotj commented Jan 7, 2025

Looks like there are a couple of headers missing from deps:

RROR: /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-0fa4d7efdb845c524-1/redpanda/redpanda/src/v/storage/tests/BUILD:3:25: Run clang-tidy on src/v/storage/tests/storage_e2e_fixture.h failed: (Exit 1): clang_tidy failed: error executing ClangTidy command (from target //src/v/storage/tests:storage_e2e_fixture) bazel-out/k8-fastbuild/bin/external/bazel_clang_tidy~/clang_tidy/clang_tidy bazel-out/k8-fastbuild/bin/external/toolchains_llvm~~llvm~llvm_18_toolchain/clang-tidy ... (remaining 41 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
2 warnings and 1 error generated.
Error while processing /root/.cache/bazel/_bazel_root/941d6faeccb295c3797fabaab1d25a0d/sandbox/linux-sandbox/33/execroot/_main/src/v/storage/tests/storage_e2e_fixture.h.
/root/.cache/bazel/_bazel_root/941d6faeccb295c3797fabaab1d25a0d/sandbox/linux-sandbox/33/execroot/_main/src/v/storage/tests/storage_e2e_fixture.h:10:10: error: 'redpanda/tests/fixture.h' file not found [clang-diagnostic-error]
   10 | #include "redpanda/tests/fixture.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
/root/.cache/bazel/_bazel_root/941d6faeccb295c3797fabaab1d25a0d/sandbox/linux-sandbox/33/execroot/_main/src/v/storage/tests/storage_e2e_fixture.h:18:8: warning: constructor does not initialize these fields: test_local_cfg [cppcoreguidelines-pro-type-member-init,hicpp-member-init]
   18 | struct storage_e2e_fixture : public redpanda_thread_fixture {
      |        ^
   19 |     scoped_config test_local_cfg;
      |
      |                                 {}
Found compiler error(s).
ERROR: /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-0fa4d7efdb845c524-1/redpanda/redpanda/src/v/storage/tests/BUILD:14:25: Run clang-tidy on src/v/storage/tests/manual_mixin.h failed: (Exit 1): clang_tidy failed: error executing ClangTidy command (from target //src/v/storage/tests:manual_mixin) bazel-out/k8-fastbuild/bin/external/bazel_clang_tidy~/clang_tidy/clang_tidy bazel-out/k8-fastbuild/bin/external/toolchains_llvm~~llvm~llvm_18_toolchain/clang-tidy ... (remaining 41 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
4 warnings and 1 error generated.
Error while processing /root/.cache/bazel/_bazel_root/941d6faeccb295c3797fabaab1d25a0d/sandbox/linux-sandbox/2/execroot/_main/src/v/storage/tests/manual_mixin.h.
/root/.cache/bazel/_bazel_root/941d6faeccb295c3797fabaab1d25a0d/sandbox/linux-sandbox/2/execroot/_main/src/v/storage/tests/manual_mixin.h:10:10: error: 'test_utils/scoped_config.h' file not found [clang-diagnostic-error]
   10 | #include "test_utils/scoped_config.h"

@dotnwat dotnwat force-pushed the storage-tests branch 2 times, most recently from d41e950 to 0b3b2f1 Compare January 7, 2025 22:52
@rockwotj
Copy link
Contributor

rockwotj commented Jan 8, 2025

Error while processing /root/.cache/bazel/_bazel_root/583d19325e4be0b858bc453b17086d6d/sandbox/linux-sandbox/3124/execroot/_main/src/v/storage/tests/storage_e2e_fixture.h.
/root/.cache/bazel/_bazel_root/583d19325e4be0b858bc453b17086d6d/sandbox/linux-sandbox/3124/execroot/_main/src/v/storage/tests/storage_e2e_fixture.h:23:16: error: no member named 'kafka_produce_transport' in namespace 'tests' [clang-diagnostic-error]
   23 |         tests::kafka_produce_transport producer(co_await make_kafka_client());

@dotnwat dotnwat removed request for rockwotj and andrwng January 8, 2025 15:37
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat dotnwat enabled auto-merge January 8, 2025 19:30
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#60443
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60443#01944759-128b-43b2-b57e-f55e14790ccd FLAKY 1/2

@dotnwat dotnwat merged commit c12269f into redpanda-data:dev Jan 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants